Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) sebm-google-map-container css class is not working. #162

Closed
parmod-arora opened this issue Feb 25, 2016 · 4 comments
Closed

(bug) sebm-google-map-container css class is not working. #162

parmod-arora opened this issue Feb 25, 2016 · 4 comments
Labels
comp: AgmMap P0: critical type: bug

Comments

@parmod-arora
Copy link
Contributor

If I remove sebm-google-map-container class from index.html file and try to use in component's style then it is not working. It was working in previous version but not in 0.8.0

I tried replicate the issue on plunk, please have a look.
http://plnkr.co/edit/iPNCoiJ8tFMaDOKsvsHi?p=preview
@sebholstein
Copy link
Owner

@parmod-arora thanks for reporting. I will fix it in v0.8.1 (and then merge your getMap() PR)

@parmod-arora
Copy link
Contributor Author

I found the work around for this issue and map is rendering now.

http://plnkr.co/edit/VEnZQD2IfAt37PTdq7Ji?p=preview

@parmod-arora
Copy link
Contributor Author

@SebastianM please have a look and provide your thoughts on the this.

sebholstein added a commit that referenced this issue Feb 27, 2016
@sebholstein
fix(SebmGoogleMap): allow styling via comp styles
8889bd2 
With v0.8.0, styling the map via the styles setting
of a component was NOT possible any more:

```
@component({
	selector: 'my-map-cmp',
	directives: [SebmGoogleMap],
	styles: [`
		.sebm-google-map-container {
			height: 300px;
	 	}
	`]
}
```

Fixes #162
@sebholstein sebholstein mentioned this issue Feb 27, 2016
Closed
@sebholstein
Copy link
Owner

@parmod-arora Thanks for digging a little bit deeper.

I've fixed this bug by enabling the old behavior of the component (since there is currently no good way to style inner elements of a component that use ViewEncapsulation.Emulated). So no need to use ViewEncapsulation.Native, which is a lot better IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: AgmMap P0: critical type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebholstein @parmod-arora