Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding penalty_factor to CoxPHSurvivalAnalysis #102

Closed
hermidalc opened this issue Mar 22, 2020 · 2 comments · Fixed by #106
Closed

Adding penalty_factor to CoxPHSurvivalAnalysis #102

hermidalc opened this issue Mar 22, 2020 · 2 comments · Fixed by #106

Comments

@hermidalc
Copy link
Contributor

hermidalc commented Mar 22, 2020

It would be very useful to also support a penalty_factor in CoxPHSurvivalAnalysis in order to always include unpenalized covariates in the model. This is important when you need to adjust for e.g. known prognostic clinical or molecular covariates which shouldn't be penalized. This is something supported for Cox ridge regression in for example the penalized R package.

@hermidalc
Copy link
Contributor Author

For now I've worked out and tested a workaround using CoxnetSurvivalAnalysis settings to become L2 penalized Ridge regression and produce identical results to CoxPHSurvivalAnalysis using information #42. This allows me to use and set penalty_factor to 0 for these covariates.

sebp added a commit that referenced this issue Apr 11, 2020
Can be used to have features entering the model unpenalized.

Fixes #102
@sebp sebp closed this as completed in #106 Apr 11, 2020
sebp added a commit that referenced this issue Apr 11, 2020
Can be used to have features entering the model unpenalized.

Fixes #102
@hermidalc
Copy link
Contributor Author

Dear @sebp - I know I'm not supposed to ask survival analysis questions here, and I did post a question on Cross Validated, but I would appreciate very much you feedback because after doing a literature search I cannot find any answers.

When running non-Cox, non-regression scikit-survival ML survival analysis methods, for example FastSurvivalSVM, GradientBoostingSurvivalAnalysis, or RandomSurvivalForest, how do you account/adjust for known prognostic clinical or molecular covariates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant