Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added backward support for gcc-c++ #255

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

navashiva
Copy link

@navashiva navashiva commented Apr 13, 2022

Checklist

  • py.test passes
  • code is well formatted
  • further testing on C++ compilers >=10

What does this implement/fix? Explain your changes

Ability to install the package against C/C++ compiler versions <10. Running into following issue during installation of the package

Error: 'isfinite' was not declared in this scope!

The fix is tested against version gcc-c++ version 4.8 that gets shipped with RHEL 7.

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #255 (24b6430) into master (bfd1005) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files          37       37           
  Lines        3229     3229           
  Branches      518      518           
=======================================
  Hits         3176     3176           
  Misses         28       28           
  Partials       25       25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd1005...24b6430. Read the comment docs.

@sebp sebp merged commit efaf92e into sebp:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants