[DOC] fix GradientBoostingSurvivalAnalysis docstring on criterion parameter

[fkiraly]

Fixes #448, under the assumption that the issue is with the docstring, not the logic.

[sebp]

Thanks for noticing!

For consistence with sklearn, and to make it easier to track changes, I'd prefer to copy the API doc from sklearn. This would also remove "mae", which isn't supported by BaseGradientBoosting.

https://github.com/scikit-learn/scikit-learn/blob/f07e0138bfee41cd2c0a5d0251dc3fe03e6e1084/sklearn/ensemble/_gb.py#L1159-L1164

[fkiraly]

of course, done

[fkiraly]

Thanks for noticing!

PS, it was actually the tests in skpro that noticed. Was churning through (assumed) parameter settings and it raised an error.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (6782d8e) to head (a0cc3f4).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files          37       37           
  Lines        3526     3526           
  Branches      539      539           
=======================================
  Hits         3461     3461           
  Misses         31       31           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sebp]

@fkiraly Thank you. Merged in commit f5e7c04

[fkiraly]

... why did you close this and merge a copy, @sebp?

[sebp]

I squashed your commits before merging.