Fix FastUpdateModel docstrings #627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docstrings of the FastUpdateModel abstract methods seemed to be in error; I believe this is what is meant, but please double-check.
st--
commented
Sep 20, 2022
| @@ -224,7 +224,7 @@ def conditional_predict_joint( | |||
| :param additional_data: Dataset with query_points with shape [..., N, D] and observations | |||
| with shape [..., N, L] | |||
| :return: The mean and covariance of the joint marginal distribution at each batch of points | |||
There was a problem hiding this comment.
Also, what is the "joint marginal distribution"? is this the joint distribution over all fs? So should this be
Suggested change
| :return: The mean and covariance of the joint marginal distribution at each batch of points | |
| :return: The mean and covariance of the joint distribution at each batch of points |
?
|
good to hear from you @st-- ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docstrings of the FastUpdateModel abstract methods seemed to be in error; I believe this is what is meant, but please double-check.