Skip to content

Commit

Permalink
type conversion in yacl/io/rw (#86)
Browse files Browse the repository at this point in the history
* Update leveldb_kvstore.cc

Add some missing terms. And the parameters of SPDLOG_INFO() are better to be strings.

* Update leveldb_kvstore.cc

* Update leveldb_kvstore.cc

* Delete csv_reader.cc

* Delete csv_writer.cc

* type conversion of enum type

"type" changed to "static_cast<int>(type)"
  • Loading branch information
maths644311798 authored Jul 15, 2023
1 parent a85ab1f commit 1189432
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions yacl/io/rw/csv_reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ void CsvReader::BuildMmapFiles() {
break;
}
default:
YACL_THROW("unknow Schema::type {}", type);
YACL_THROW("unknow Schema::type {}", static_cast<int>(type));
}
}
}
Expand Down Expand Up @@ -346,7 +346,7 @@ bool CsvReader::NextCol(ColumnVectorBatch* data) {
break;
}
default:
YACL_THROW("unknow Schema::type {}", type);
YACL_THROW("unknow Schema::type {}", static_cast<int>(type));
}

return true;
Expand Down Expand Up @@ -377,7 +377,7 @@ void CsvReader::InitBatchCols(std::vector<ColumnType>* cols,
break;
}
default:
YACL_THROW("unknow Schema::type {}", type);
YACL_THROW("unknow Schema::type {}", static_cast<int>(type));
}
}
}
Expand Down Expand Up @@ -443,7 +443,7 @@ bool CsvReader::NextRow(ColumnVectorBatch* data, size_t batch_size) {
break;
}
default:
YACL_THROW("unknow Schema::type {}", type);
YACL_THROW("unknow Schema::type {}", static_cast<int>(type));
}
}
}
Expand Down Expand Up @@ -512,4 +512,4 @@ std::unique_ptr<Reader> CsvReader::Spawn() {
return ret;
}

} // namespace yacl::io
} // namespace yacl::io
4 changes: 2 additions & 2 deletions yacl/io/rw/csv_writer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ bool CsvWriter::Add(const ColumnVectorBatch& data) {
break;
}
default:
YACL_THROW("unknow Schema::type {}", types[c]);
YACL_THROW("unknow Schema::type {}", static_cast<int>(types[c]));
}
if (c + 1 != cols) {
out_->Write(field_delimiter_.c_str(), field_delimiter_.size());
Expand All @@ -99,4 +99,4 @@ bool CsvWriter::Add(const ColumnVectorBatch& data) {
return true;
}

} // namespace yacl::io
} // namespace yacl::io

0 comments on commit 1189432

Please sign in to comment.