Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-fixes/ NFT dashboard, detail and send (window view) #82

Closed
36 of 38 tasks
QUDBS opened this issue Nov 23, 2022 · 0 comments · Fixed by #98
Closed
36 of 38 tasks

ui-fixes/ NFT dashboard, detail and send (window view) #82

QUDBS opened this issue Nov 23, 2022 · 0 comments · Fixed by #98
Assignees
Labels

Comments

@QUDBS
Copy link

QUDBS commented Nov 23, 2022

Screenshot 2022-11-24 at 18 08 18

  • Could we have a general loading instead of all assets loading one by one?

Screenshot 2022-11-23 at 10 17 32

  • Open web gallery in 80% opacity
  • Open web gallery 16px from the previous element
  • Buttons spacing between each other: 12px + everything mentioned in ui-fixes/ Button Component #57
  • No border/card around an NFT
  • NFT title aligned left
  • Every NFT has a border radius of 8px
  • If a NFT is not a square, let's crop it in the dashboard view
  • The BNS picture is a square
  • Header has to align the same as on other pages (it's not aligned when moving from dashboard - nft - stacking)
  • Last row of NFTs 40px from tab bar

Screenshot 2022-11-23 at 10 56 13

  • "by" with a non capitalised B
  • Open web gallery in 80% opacity
  • NFT size is 148px x 148px if square. If rectangular, the height is always 148px, the width adapts
  • NFT radius 8px
  • Content is 32px from header
  • Buttons spacing between each other: 12px + everything mentioned in ui-fixes/ Button Component #57

Screenshot 2022-11-23 at 11 06 24

  • NFT size is 148px x 148px if square. If rectangular, the height is always 148px, the width adapts
  • NFT radius 8px
  • Content is 32px from header
  • The NFT and title shouldn't be moving when going from detail to send
  • Recipient* not recepient
  • Field can be higher, 32px from NFT title
  • Field 44px height

Screenshot 2022-11-23 at 11 17 37

Same as in #77

  • Color alteration between bns name and address
  • Separator is 1px
  • Better align the icon on the right of the address
  • Missing "You will send"
  • Button are fixed on the bottom
  • Advanced settings is 14px
  • More space above and below the separator (24px each)
  • NFT can be smaller, 120 x 120

Screenshot 2022-11-23 at 11 20 41

  • Close button 64px from bottom
  • Better align "Transaction ID"
  • Capitalised "Transaction ID"
  • Less spacing between transaction ID and the ID
  • Use the feedback behavior posted above to copy the ID
  • The content from the check icon to "see on stacks explorer" can be above - 92px from top
@QUDBS QUDBS added the ui label Nov 23, 2022
@QUDBS QUDBS added this to the Sprint 22 - Dec 12 milestone Nov 23, 2022
@Imamah-Zafar Imamah-Zafar linked a pull request Nov 28, 2022 that will close this issue
7 tasks
@Imamah-Zafar Imamah-Zafar self-assigned this Nov 30, 2022
teebszet pushed a commit that referenced this issue Mar 5, 2024
* [ENG-3710] fix: Fix UI issues related to account management

* Use the ui-library/button component, deprecate the ActionButton

* Improve the account name validation

* Improve the account name validation
teebszet pushed a commit that referenced this issue May 31, 2024
* [ENG-3710] fix: Fix UI issues related to account management

* Use the ui-library/button component, deprecate the ActionButton

* Improve the account name validation

* Improve the account name validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants