chore(contracts): rewrite getEpochReward and add getEpochAllocation #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@developerfred In #56 this was implemented by only including epochs that have at least 1 contribution. So if an epoch had zero contributions, its funding would be shifted to the following epoch. Does this PR have that same logic, or did you have another idea in mind? |
|
@aahna-ashina This pull request involves calculating the allocation based on the contribution made. If I did not contribute in the epoch, I do not have the right to calculate the allocation. I understand that the implementation of #56 has an additional feature, which allows the allocation to be transferred to the next epoch. Therefore, we can close this pull request. |
|
Superseded by #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
closes #24
How Has This Been Tested?
Sector#3 Contribution