Double-check that GPG tests run where expected. #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite passes even if GPG is not available, because GPG-dependent tests are skipped if GPG is not present. This change asserts the availability of GPG, so CI environments that expect GPG will notice if it goes away unexpectedly rather than silently skipping the GPG tests. Signed-off-by: Zachary Newman <[email protected]>
3 tasks
znewman01
added a commit
to znewman01/securesystemslib
that referenced
this pull request
Oct 13, 2022
Fixes secure-systems-lab#428. Okay to do this because we will fail tests if GPG is unexpectedly unavailable (secure-systems-lab#434). Signed-off-by: Zachary Newman <[email protected]>
znewman01
added a commit
to znewman01/securesystemslib
that referenced
this pull request
Oct 13, 2022
Fixes secure-systems-lab#428. Okay to do this because we will fail tests if GPG is unexpectedly unavailable (secure-systems-lab#434). Signed-off-by: Zachary Newman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite passes even if GPG is not available, because GPG-dependent tests are skipped if GPG is not present.
This change asserts the availability of GPG, so CI environments that expect GPG will notice if it goes away unexpectedly rather than silently skipping the GPG tests.
Signed-off-by: Zachary Newman [email protected]
Addresses (does not fix): #428
Please verify and check that the pull request fulfils the following requirements: