Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Libp2p relay reconnection issues #774

Closed
burdiyan opened this issue Sep 26, 2022 · 7 comments
Closed

[bug] Libp2p relay reconnection issues #774

burdiyan opened this issue Sep 26, 2022 · 7 comments
Assignees
Labels
priority: high Critical to have scope: daemon Daemon and p2p networking scope: network type: bug Something isn't working

Comments

@burdiyan
Copy link
Collaborator

After removing our fork of libp2p and updating to the newest version, we continue having issues with relay connectivity.

  1. Even if relay is configured as static - on failed reconnection the client forgets this relay forever. Submit PR to fix that.
  2. When the client loses network, the relay will remove the reservation, so the client should reserve again after reconnecting.
@juligasa
Copy link
Collaborator

As for the connection issues it's resolved with 4c88550. I will open an issue in go-libp2p so they can include something similar and we don't need to use our own fork

@burdiyan
Copy link
Collaborator Author

@juligasa Great! Please post here the link to the issue in libp2p when you open it.

@juligasa
Copy link
Collaborator

@juligasa Great! Please post here the link to the issue in libp2p when you open it.

libp2p/go-libp2p#1782

@GaboHBeaumont GaboHBeaumont changed the title Libp2p relay reconnection issues [bug] Libp2p relay reconnection issues Oct 3, 2022
@GaboHBeaumont
Copy link

so we should close the issue?

@GaboHBeaumont GaboHBeaumont added the priority: high Critical to have label Oct 3, 2022
@burdiyan
Copy link
Collaborator Author

burdiyan commented Oct 3, 2022

I think we should close whenever libp2p accepts our PR and we use the upstream version instead of our fork.

@GaboHBeaumont
Copy link

GaboHBeaumont commented Oct 11, 2022 via email

@juligasa
Copy link
Collaborator

merged here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Critical to have scope: daemon Daemon and p2p networking scope: network type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants