Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔥 remove lines and files since they are in template now #177

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

lwjohnst86
Copy link
Member

Description

Since I made a template repo at template-python-project, we don't need to keep these files and lines here. So removed the.

See #170

Reviewer Focus

This PR needs a quick review.

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner September 9, 2024 14:29
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to split things up with the python project template repo 🌟
I don't approve just yet, only because of my question about removing the R related files in gitignore. Otherwise it's great 👌

.gitignore Outdated Show resolved Hide resolved
@lwjohnst86 lwjohnst86 merged commit 62ed246 into main Sep 16, 2024
@lwjohnst86 lwjohnst86 deleted the chore/remove-files-moved-to-template-repo branch September 16, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants