-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: transfer of text about runtime uploads #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transfer and update of the text describing the way users will get data into Seedcase
Just did some initial minor edits - will read through the runtime-view post tomorrow |
signekb
reviewed
Dec 28, 2023
No idea what I'm doing with this Commit button, but here goes :-) Co-authored-by: Signe Kirk Brødbæk <[email protected]>
This was referenced Jan 2, 2024
lwjohnst86
previously approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!! I'm making some small changes, will push and than merge 😁
lwjohnst86
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transfer and update of the text describing the way users will get data into Seedcase
most of this is text from the original Seedcase repo. It's been updated with a few lines about batch uploads. The links to the diagrams are broken, there are todo's on all of them to make them into pngs and get them integrated, but one is waiting for another PR do be done.
Focus for reviewers:
That the text hasn't been cut in a way that it no longer makes sense. Also, a small bit has been commented out, it would be good to have a discussion of whether or not it should go back in.