Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 🔧 Update pyproject file and add Ruff to Poetry #47

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

lwjohnst86
Copy link
Member

I've updated the configuration pyproject.toml file with metadata on using Poetry to manage our package dependencies. I've also added Ruff (Python code formatter/linter) to the installation settings of Poetry.

Closes #13.

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner January 2, 2024 12:26
@lwjohnst86
Copy link
Member Author

lwjohnst86 commented Jan 2, 2024

Oops, made this merge into another branch. Oh well, I'll let this be approved and merged first.

K-Beicher
K-Beicher previously approved these changes Jan 2, 2024
Copy link
Contributor

@K-Beicher K-Beicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume that there will be a review by someone who knows more about this. Both links to GitHub works, but there isn't a working homepage yet, should there be?

@lwjohnst86
Copy link
Member Author

@K-Beicher the website hasn't been built yet, so this is a placeholder for now 😝

@signekb
Copy link
Member

signekb commented Jan 2, 2024

Also looks good to me 👍

Base automatically changed from chore/conventional-branch-settings to main January 2, 2024 15:35
@lwjohnst86 lwjohnst86 dismissed K-Beicher’s stale review January 2, 2024 15:35

The base branch was changed.

@lwjohnst86 lwjohnst86 merged commit 0b24735 into main Jan 2, 2024
@lwjohnst86 lwjohnst86 deleted the build/update-poetry-details branch January 2, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Managing Python dependencies
3 participants