Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix knex getter when undefined on model class #27

Merged
merged 1 commit into from
May 15, 2020
Merged

Fix knex getter when undefined on model class #27

merged 1 commit into from
May 15, 2020

Conversation

nuno-vieira-deel
Copy link
Contributor

This PR aims to fix knex getter when undefined on model class. When knex is not added directly on the model class, the plugin now uses the context.transaction value as a fallback.

@nuno-vieira-deel nuno-vieira-deel force-pushed the bugfix/fix-get-knex-when-not-in-model branch from 3fa3750 to 9a2b9a3 Compare May 15, 2020 14:42
@joaonice joaonice merged commit 1812934 into master May 15, 2020
@joaonice joaonice deleted the bugfix/fix-get-knex-when-not-in-model branch May 15, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaonice joaonice Awaiting requested review from joaonice

Assignees

@joaonice joaonice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuno-vieira-deel @joaonice