Fix leaking transaction, favor transaction from context over creating new one #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing operations within a transaction a new one was started rather than using the current one, causing a "leaking" connection. This became more evident when trying to run tests with only 1 connection pool.
|
@dawaa thank you |
|
@joaonice nice to see it merged so quickly, thanks. do you think it's possible to get a release out with this change in the near future? |
|
@dawaa version |
|
@joaonice superb, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing operations within a transaction a new one was started rather
than using the current one, causing a "leaking" connection. This became
more evident when trying to run tests with only 1 connection pool.