Don't show the ghost positional argument args #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fixed by: ``` wrapper.__signature__ = inspect.signature(func) ``` But in doing so it forces all @arg decorators to reference arguments in the function signature. Therefore `--profile` can't exist because it doesn't match a function argument. It has been renamed to `--config`. Also, because --config is optional on the CLI, the function signature needs to provide a default even though it's mandatory for the function. Because python syntax doesn't allow non-default arguments to follow default arguments it has been moved to be the last argument.
This was referenced Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't show the ghost positional argument
args(fixes #145)
This is fixed by:
But in doing so it forces all @arg decorators to reference arguments in
the function signature. Therefore
--profilecan't exist because itdoesn't match a function argument. It has been renamed to
--config.Also, because
--configis optional on the CLI, the function argumentneeds to provide a default even though it's mandatory for the function.
Because python syntax doesn't allow non-default arguments to follow
default arguments it has been moved to be the last argument.