ci: refactor to use ruff and black non-local hooks #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekumara
added a commit
that referenced
this pull request
Jul 13, 2024
align with [python-typed-template](https://github.com/tekumara/python-typed-template/tree/518252bdc6eaa21043b929e074a03c1da6126db2) ruff is now installed into the venv rather than as a pre-commit hook, reversing #443 and reintroducing knowledge of .venv into .pre-commit-config.yaml. This is advantageous until [Dependabot supports updating pre-commit hooks](dependabot/dependabot-core#1524) and also means `ruff check .` can be run locally. toast: install hooks during install step so they are cached
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to remove knowledge of .venv (which is determined by the Makefile) from the pre-commit hooks
this also seems to be more canonical (eg: black, ruff)
originally they were local so we could use them:
make checknow calls pre-committhe trade-off is that we won't have version parity between vs code and pre-commit (likewise, we don't already have this between pyright and pylance)