Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LF-52351 Adding ci #108

Merged
merged 5 commits into from
Sep 6, 2024
Merged

LF-52351 Adding ci #108

merged 5 commits into from
Sep 6, 2024

Conversation

XavierMilesSeequent
Copy link
Contributor

No description provided.

@XavierMilesSeequent XavierMilesSeequent marked this pull request as ready for review August 21, 2024 03:38
@XavierMilesSeequent
Copy link
Contributor Author

@tim-mitchell I'm giving up on the automatic Jira commit message for now and have put details into LF-54861. I think the testing + autoformatting is useful enough for now and it would be useful to replicate that elsewhere in LF-54857/LF-54860 before trying to do harder stuff with pre-commit 🙂

@XavierMilesSeequent
Copy link
Contributor Author

@tim-mitchell after merging this, do you want to create a new release? I guess it's only worth it if you think it's worth keeping leapfrog absolutely up-to-date with the state of this code, as the black/isort changes shouldn't make any functional difference.

@XavierMilesSeequent XavierMilesSeequent merged commit 588ef6e into master Sep 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-mitchell tim-mitchell tim-mitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XavierMilesSeequent @tim-mitchell