Adding .editorconfig and applying naming conventions #26
Conversation
| Add(new UserInfoPlugin()); | ||
| _ = this.Add(new StartupQueue()); | ||
| _ = this.Add(new ContextPlugin()); | ||
| _ = this.Add(new UserInfoPlugin()); |
There was a problem hiding this comment.
we probably should just ignore the return values. this looks bad imo
| userInfo.traits = null; | ||
| this._userInfo._userId = null; | ||
| this._userInfo._anonymousId = null; | ||
| this._userInfo._traits = null; |
There was a problem hiding this comment.
I forgot about this last time. it's probably better that we just create a new UserInfo here, instead of assigning the properties one by one. also, assigning anonymousId as null actually introduce a bug, since the ResetAction below actually gives a random uuid, which creates a inconsistent image between memory and sovran.
refer to the kotlin counterpart here for solution.
| public JsonObject integrations; | ||
| public JsonObject plan; | ||
| public JsonObject edgeFunctions; | ||
| #pragma warning disable IDE1006 // Naming Styles |
There was a problem hiding this comment.
why do we need this pragma? is it for disable warnings from the IDE? if so, we don't have to have it in the code
|
|
||
| System(Configuration configuration, Settings settings, bool running) | ||
| private System(Configuration configuration, Settings settings, bool running) |
There was a problem hiding this comment.
this should not be private. it's possible that we create a System state directly instead of through DefaultState. we don't need to apply every IDE suggestions.
|
|
||
| UserInfo(string anonymousId, string userId, JsonObject traits) | ||
| private UserInfo(string anonymousId, string userId, JsonObject traits) |
|
|
||
| // backing fields that holds the actual string representation | ||
| // needed for switch statement, has to be compile time available | ||
| #pragma warning disable IDE1006 |
…into MichaelGHSeg/LIBMOBILE-1095
Co-authored-by: Wenxi Zeng <[email protected]>
…entio/Analytics-CSharp into MichaelGHSeg/LIBMOBILE-1095
No description provided.