This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change, but let me explain why we need it.
We have a
div
surrounding ourConsentManager
component. Thatdiv
applies styles, including a banner:...which renders to the DOM as:
If the user accepts cookies and the banner disappears, then the DOM is now:
i.e. our wrapper
div
, containing an emptydiv
. The wrapper div is thus 0px * 0px, but the border is still visible, seen as a 2px square on the page.This PR removes the empty
div
, replacing it with aReact.Fragment
. If none of the conditions are met in thecontainer.tsx
render, then only an empty Fragment is returned, which results in nothing being added to the DOM, and we can therefore hide the empty wrapperdiv
at our end with some CSS: