Configure keys file path from environment variable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add required length argument to to_bytes function
|
Hi! Thanks for PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to externally configure NSTools to look for the keys file based on the environment variable
NSTOOLS_KEYS_FILE, so the possible paths are not exclusively harcoded.If the environment variable is not set, it will output
or $NSTOOLS_KEYS_FILE not found, or its value if it is defined but not a file.This also fix the
ns_extractscripts, where thelengthargument is missing in theto_bytescalls. I don't know if the length can be hardcoded so the value is set according to SO.