Removes 'none' classes after selection change #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seiyria
reviewed
Nov 23, 2016
| @@ -689,6 +689,12 @@ const windowIsDefined = (typeof window === "object"); | |||
| this._addClass(this.trackHigh, 'hide'); | |||
| } | |||
|
|
|||
| else if (this.options.selection === 'after' || this.options.selection === 'before') { | |||
|
looks good to me. @rovolution ? |
|
this is a great PR! Thank again for making this very high-quality PR @john-clarke! |
|
@rovolution Glad it worked out. bootstrap-slider has been a very useful package to us this year. This PR was just a small contribution to your work. Thank you for keeping it going! |
|
merged and published to 9.5.1. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #658