Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selection of surrounding DOM elements while sliding in FF and IE #829

Merged
merged 1 commit into from
Apr 29, 2018
Merged

Fix selection of surrounding DOM elements while sliding in FF and IE #829

merged 1 commit into from
Apr 29, 2018

Conversation

wulfsoft
Copy link
Contributor

I fixed the issue described in #746.

@seiyria
Copy link
Owner

seiyria commented Apr 22, 2018

please provide a jsfiddle of your fix

@wulfsoft
Copy link
Contributor Author

Before: https://jsfiddle.net/c0703sLb/
After: https://jsfiddle.net/c0703sLb/1/

Use Firefox or Internet Explorer and move the handle around to see how the surrounding text is selected.

selected-text-ff

rovolution
rovolution approved these changes Apr 29, 2018
View reviewed changes
Copy link
Collaborator

@rovolution rovolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rovolution
Copy link
Collaborator

just pulled it down and ran locally and it works! Thanks for your contribution @wulfsoft!

@rovolution rovolution merged commit 83ba16e into seiyria:master Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rovolution rovolution rovolution approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wulfsoft @seiyria @rovolution