Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger change on either range value #897

Merged
merged 2 commits into from
Dec 18, 2018

Conversation

pimlie
Copy link
Contributor

@pimlie pimlie commented Dec 18, 2018

Pull Requests

Please accompany all pull requests with the following (where appropriate):

  • unit tests (we use Jasmine 2.x.x)
  • JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
  • Link to original Github issue (if this is a bug-fix)
  • documentation updates to README file
  • examples within /tpl/index.tpl (for new options being added)
  • Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

PR #879 / v10.3.4 introduced an issue for range sliders as a change event was only triggered when both lower and upper value changed. See pimlie/vue-bootstrap-slider#11 for downstream issue. This PR fixes that.

@u01jmg3
Copy link

u01jmg3 commented Dec 18, 2018

Correction: it was PR #879 (8b5ad4d)

@viceice
Copy link
Contributor

viceice commented Dec 18, 2018

fixes #898 too 👍

@jespirit
Copy link
Collaborator

I'm on it. Let me just add a unit test. Was my fault.

@jespirit jespirit merged commit 6832c1c into seiyria:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants