Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload not working (windows 8.1) #21

Closed
awhitehouse104 opened this issue May 23, 2016 · 2 comments
Closed

Hot reload not working (windows 8.1) #21

awhitehouse104 opened this issue May 23, 2016 · 2 comments

Comments

@awhitehouse104
Copy link

awhitehouse104 commented May 23, 2016

Can't speak for everyone, but I had to modify a couple of things to get hot reload to work on windows.

First, remove localhost binding in server.js (reference).

server.listen(port, (err) => {
    if (err) {
        console.error(err);
    }
    console.info('==> 🌎 Listening on port %s. Open up http://localhost:%s/ in your browser.', port, port);
});

Also, add base public path in webpack.config (reference).

output: {
    path: path.join(__dirname, 'dist'),
    filename: 'app.js',
    publicPath: '/'
},
@sekoyo
Copy link
Owner

sekoyo commented May 24, 2016

Excellent thanks, it was never working well for me good catches, note that it still won't work with react pure functional components but that's a limitation of the hot reloader (looking forward to the new one). I'll verify this later and update.

@awhitehouse104
Copy link
Author

Yes I considered playing with the new one but this fix was simple enough for now :)

sekoyo pushed a commit that referenced this issue May 31, 2016
@sekoyo sekoyo closed this as completed May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants