-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autocomplete="off"
is broken, use another value like autocomplete="nonono"
. Also add autofill="nonono"
#1535
Comments
Why does this change unconditionally add |
Apart from being incorrect and unconfigurable, this is causing havoc with extensions that listen for password autocompletes. For Last Pass I ended up having to add this to forcably remove the autocomplete and force the last pass extension to ignore the selectize input
|
NOOO, Regressions! |
On my GitHub profile I wrote an article about this Autocomplete issue. It's a boring thing. There are several ways to fix this problem, the best way is to generate a random string to put in the autocomplete property every time the Input is rendered. This is the only way to guarantee that the autocomplete will never appear, generating a random string every time the page is loaded. Example: autocomplete="af2f90" My article: https://gist.github.com/eduardo-mior/ad14cab17fb5ab641812bff622534353 All other solutions, like for example autocomplete="new-password" or autocomplete="none" or autocomplete="nonono" will fail after a few dozen accesses. Google Chrome understands that that field has already been filled in several times and starts making suggestions. If we use an always random autocomplete, it will never find a cache for that field because the autocomplete is never the same. |
@eduardo-mior the writeup you did is fantastic! thank you for the research that you have put in. |
It is a good write up, but we should test all the untested ones. |
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days |
This inside selectize fixed it for me: |
Browsers don't respect
autocomplete="off"
and try to autocomplete inputs, which blocks the dropdown. Instead you should use any other value likeautocomplete="no"
orautocomplete="justdontuseoff"
.I'd also recommend adding
autofill="no"
to the input as well.Sorry, don't have time to create a demo.
With
autocomplete="off"
:With any other value than
false
oroff
:Steps to reproduce:
<select id="country">
should workautocomplete="no"
and watch the madness evaporate.I did:
(or gave a link to a demo on the Selectize docs)
like below
The text was updated successfully, but these errors were encountered: