Use strict: true
#697
Merged
Use strict: true
#697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having `strict` off makes it harder for clients of this library to use `strict` themselves. But it appears to turn on without any type issues, so my guess is that there were tricky types in the past which have since been resolved.
|
good point. I think that I thought |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
strictoff makes it harder for clients of this library to usestrictthemselves. But it appears to turn on without any type issues, so my guess is that there were tricky types in the past which have since been resolved.I'd understand if you have reservations about turning it on, but I'd highly recommend it, given it turns on cleanly right now.