Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raised the peer requirement for semantic-release #567

Merged
merged 1 commit into from
Jan 25, 2023
Merged

raised the peer requirement for semantic-release #567

merged 1 commit into from
Jan 25, 2023

Conversation

travi
Copy link
Member

@travi travi commented Jan 18, 2023

this is a breaking change to add to the list of breakages for this beta. using a normal merge already includes the token to consider as a breakage

before we decide to merge this though, i think this is a chance to consider semantic-release/semantic-release#2670 (comment) first. the options to decide between, as i see them, are:

  • merge this PR that raises the peer requirement to the first beta of core that supports loading esm plugins, promote the beta of core still depending on a beta of the npm plugin, then raise the peer again to v21 that has been promoted to stable, and finally promote the npm plugin to stable
  • backport the support for loading esm plugins to v20 of core, update the peer requirement here to the v20 version that supports esm plugins, promote the npm plugin to stable, promote core to stable

@gr2m
Copy link
Member

gr2m commented Jan 18, 2023

backport the support for loading esm plugins to v20 of core, update the peer requirement here to the v20 version that supports esm plugins, promote the npm plugin to stable, promote core to stable

I'd prefer that option, unless you think it would be much more work? Maybe I miss something but think it should be fairly straight forward to do

@travi
Copy link
Member Author

travi commented Jan 19, 2023

This is my preferred direction as well

@travi travi force-pushed the sr-peer branch 2 times, most recently from c344057 to e240709 Compare January 25, 2023 05:39
…he first version that supports loading esm plugins

BREAKING CHANGE: the required version of semantic-release has been
raised to v20.1.0 in order to support loading of ESM plugins
@travi travi merged commit 2b8ac2e into beta Jan 25, 2023
@travi travi deleted the sr-peer branch January 25, 2023 12:52
@github-actions
Copy link

🎉 This PR is included in version 10.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants