Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dingtalk webhook notification medium #2363

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

shaxiaozz
Copy link
Contributor

Hello, we need to use DingTalk's webhook notification, so we added the code of this notification medium, hoping to merge it in. Because we will push the platform to the production environment for formal use. Thank you~

This code has been tested and verified in the local development environment, and the following is the effect diagram:
image

@shaxiaozz
Copy link
Contributor Author

Related issue: #2325

@fiftin fiftin merged commit ae3f878 into semaphoreui:develop Sep 27, 2024
12 checks passed
@fiftin
Copy link
Collaborator

fiftin commented Sep 27, 2024

Hi @shaxiaozz ,

Thank you for your PR! I removed the block of code which asks dingtalk options from semaphore setup because it is outdated method of configuration.

@shaxiaozz
Copy link
Contributor Author

@fiftin Thank you for your agreement to merge. At the same time, delete the obsolete code, thank you~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants