Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make requests cancellable #21

Closed
aKzenT opened this issue Jan 10, 2017 · 3 comments
Closed

Make requests cancellable #21

aKzenT opened this issue Jan 10, 2017 · 3 comments
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@aKzenT
Copy link
Contributor

aKzenT commented Jan 10, 2017

HttpClient allows cancellation via CancellationToken. Using this API it is currently not possible to pass a cancellation token. Therefore you cannot cancel long running requests.

It would be helpful in our scenario to be able to cancel running requests. CancellationToken provides a standard way to do this and it should be easy to include this as an extra parameter. Please consider it for an upcoming release.

Thanks!
@aKzenT aKzenT mentioned this issue Jan 10, 2017
Merged
@aKzenT
Copy link
Contributor Author

aKzenT commented Jan 10, 2017 •
edited
Loading

I added the necessary code in the referenced pull request. Kindly review.

@thinkingserious thinkingserious added status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Jan 25, 2017
@thinkingserious
Copy link
Contributor

Hello @aKzenT,

Checking the pull request now ...

Note that the v9beta branch of our official library will have this functionality included: https://github.com/sendgrid/sendgrid-csharp/blob/single-email/src/SendGrid/SendGridClient.cs#L254. That beta should be available no later then early next month with any luck.

With Best Regards,

Elmer

@thinkingserious
Copy link
Contributor

Closed with #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thinkingserious @aKzenT