Added cancellation of requests using CancellationToken #22
Conversation
thinkingserious
added
the
status: code review request
|
Hello @aKzenT, |
|
Hello @aKzenT, Do you mind sending over a signed CLA so I can review and merge? Thanks! |
|
Already did that a few weeks ago. Please Check!
|
|
Thanks @aKzenT, I do not see it however, can you please let me know from what email you sent it from? (Please reply to [email protected]) |
|
Hi @aKzenT, I have not received the CLA or follow up email from you. Could you please resend or let me know what email address you used to send it? Thanks! |
|
I send it again, now from another email address and to your own email address just in case. |
|
We received it, thanks! As for v9, it's available now: With Best Regards, Elmer |
CSharpHTTPClient/Client.cs
Outdated
| i++; | ||
| } | ||
| result = RequestAsync(binder.Name.ToUpper(), requestBody: requestBody, queryParams: queryParams).ConfigureAwait(false); | ||
| result = RequestAsync(binder.Name.ToUpper(), cancellationToken, requestBody: requestBody, queryParams: queryParams).ConfigureAwait(false); |
There was a problem hiding this comment.
Please move the cancellationToken parameter to the end for consistency with our v9 SDK.
CSharpHTTPClient/Client.cs
Outdated
| /// <param name="requestBody">JSON formatted string</param> | ||
| /// <param name="queryParams">JSON formatted queary paramaters</param> | ||
| /// <returns>Response object</returns> | ||
| private async Task<Response> RequestAsync(string method, string requestBody = null, string queryParams = null) | ||
| private async Task<Response> RequestAsync(string method, CancellationToken cancellationToken, string requestBody = null, string queryParams = null) |
There was a problem hiding this comment.
Please move the cancellationToken parameter to the end for consistency with our v9 SDK.
|
Hi @aKzenT, To merge this, could you please:
Thanks! |
|
Done, Thanks! |
Please see related issue #21