Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client replaces single quotes with double quotes in request payload #7

Closed
gliljas opened this issue Jun 28, 2016 · 1 comment
Closed

Client replaces single quotes with double quotes in request payload #7

gliljas opened this issue Jun 28, 2016 · 1 comment
Labels
status: help wanted requesting help from the community type: bug bug in the library

Comments

@gliljas
Copy link

gliljas commented Jun 28, 2016 •
edited
Loading

https://github.com/sendgrid/csharp-http-client/blob/master/CSharpHTTPClient/Client.cs#L311

Here, the client replaces single quotes with double quotes. That is unexpected behavior.

Single quotes are perfectly valid inside JSON string tokens.

sendgrid/sendgrid-csharp#256
@thinkingserious thinkingserious added type: bug bug in the library status: help wanted requesting help from the community labels Jun 28, 2016
@gliljas gliljas mentioned this issue Jun 28, 2016
Closed
thinkingserious added a commit that referenced this issue Jul 14, 2016
@thinkingserious
Fix for issue #7
8e4a667 
Solves sendgrid/sendgrid-csharp#256
thinkingserious added a commit that referenced this issue Jul 14, 2016
@thinkingserious
Merge pull request #12 from sendgrid/256-bad-json
e867988 
Fix for issue #7
@thinkingserious
Copy link
Contributor

Please shoot us an email at [email protected] with your T-shirt size and mailing address so we can send you some swag. Your help with identifying the issue quickly is greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted requesting help from the community type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thinkingserious @gliljas