Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure LICENSE file test works cross-platform #53

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

adlan
Copy link

@adlan adlan commented Oct 29, 2017

Fixes #51

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Use Path.Combine method instead of hard-coding platform-specific
    path separator because Travis is run on a non-windows platform

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

Use Path.Combine method instead of hard-coding platform-specific
path separator
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2017

CLA assistant check
All committers have signed the CLA.

@adlan
Copy link
Author

adlan commented Oct 29, 2017

Also, note that, this PR partially fix the failing Travis build. There are 2 more failing test, I'll see if I can fix those

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@mbernier
Copy link

@adlan you rock!! Thank you!!

@mbernier mbernier merged commit c31a9c4 into sendgrid:master Oct 31, 2017
@thinkingserious
Copy link
Contributor

Hello @adlan,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbernier
Copy link

@adlan
If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to fix Mono errors during Travis CI build?
4 participants