Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new Git workflow #78

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Document new Git workflow #78

merged 2 commits into from
Aug 14, 2019

Conversation

gr8shivam
Copy link
Contributor

Fixes #75

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Update CONTRIBUTING.md to for devs to branch off from development instead of master

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 13, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 13, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@devchas devchas added difficulty: easy fix is easy in difficulty good first issue type: docs update documentation change not affecting the code labels Oct 17, 2018
@thinkingserious thinkingserious mentioned this pull request Nov 2, 2018
Closed
@thinkingserious thinkingserious merged commit db9f1ec into sendgrid:master Aug 14, 2019
@thinkingserious
Copy link
Contributor

Hello @gr8shivam,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document new Git workflow in CHANGELOG.md
4 participants
@gr8shivam @SendGridDX @thinkingserious @devchas