Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken feature request link #83

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

sanjaysingh
Copy link
Contributor

@sanjaysingh sanjaysingh commented Oct 26, 2018

Fixed broken feature request link

Fixes

Fixes broken feature request link

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fixes broken feature request link on the readme page

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

Fixed broken feature request link
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 26, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 26, 2018

CLA assistant check
All committers have signed the CLA.

@sanjaysingh
Copy link
Contributor Author

CI build is failing with following error

System.IO.FileNotFoundException : Could not find file "/home/travis/build/sendgrid/csharp-http-client/LICENSE.txt"

It seems unrelated to my changes and i am not sure what to do.

Fixed link to MIT license file
@sanjaysingh
Copy link
Contributor Author

I noticed that license file link was broken as well so updated that. If we can somehow kick the build again it should work.

@sanjaysingh
Copy link
Contributor Author

Still failed. I think license file needs to be renamed to License.txt from License.md. If that is the case i would raise another clean Pull request with the file renamed as well as link to 'feature request' link.

@crweiner
Copy link
Contributor

@sanjaysingh There are currently two PRs to fix the Travis errors. The first is in #77, so hopefully it will be merged soon and you don't have to worry about the Travis flag. 👍

@thinkingserious thinkingserious merged commit 14c3ec2 into sendgrid:master Aug 14, 2019
@thinkingserious
Copy link
Contributor

Hello @sanjaysingh,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants