Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #84

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Update README.md #84

merged 1 commit into from
Aug 14, 2019

Conversation

vyaspranjal33
Copy link
Contributor

@vyaspranjal33 vyaspranjal33 commented Oct 27, 2018

fixed LICENSE file extension in Link

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

fixed LICENSE file extension in Link
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 27, 2018

CLA assistant check
All committers have signed the CLA.

@aroach
Copy link
Contributor

aroach commented Oct 29, 2018

@vyaspranjal33 Can you take a look at why the build is failing?

@vyaspranjal33
Copy link
Contributor Author

vyaspranjal33 commented Oct 29, 2018

@aroach build fails because of "mono ./testrunner/NUnit.Runners.2.6.4/tools/nunit-console.exe UnitTest/bin/Release/UnitTest.dll -domain:None"

please fix it

@aroach
Copy link
Contributor

aroach commented Oct 29, 2018

It looks like it's failing when testing for LICENSE.txt: https://travis-ci.org/sendgrid/csharp-http-client/builds/447152699#L1724

@vyaspranjal33
Copy link
Contributor Author

@aroach i fixed 404 error by changing License file link in badge ,i think it can be merged

@aroach
Copy link
Contributor

aroach commented Oct 29, 2018

@vyaspranjal33 yes, i see that. I didn't notice that the build had been failing on that LICENSE.txt check for a while now. You're good then! Thanks for the PR!

@vyaspranjal33
Copy link
Contributor Author

@aroach please merge PRs , today is last day of Hacktoberfest 😅

@thinkingserious thinkingserious merged commit 45ac4ed into sendgrid:master Aug 14, 2019
@thinkingserious
Copy link
Contributor

Hello @vyaspranjal33,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants