Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Nullable support #1149

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

feat: Add Nullable support #1149

wants to merge 26 commits into from

Conversation

maxkoshevoi
Copy link
Contributor

@maxkoshevoi maxkoshevoi commented Dec 2, 2021 •
edited
Loading

Fixes

  • Add nullable annotations (C# 8 nullable support)
  • Initialize (some) collection properties
  • Style fixes related to new C# capabilities (e.g. default(T) -> default)
  • Fix httpErrorAsException argument not used in SendGridClient.cs

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Felix200521
Felix200521 approved these changes Dec 11, 2021
View reviewed changes
Copy link

@Felix200521 Felix200521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/SendGrid/Helpers/Mail/Model/Personalization.cs

@maxkoshevoi
Copy link
Contributor Author

maxkoshevoi commented Jan 5, 2022 •
edited
Loading

Ok, I'm not sure how to build this thing using latest .net sdk (6.0). Could someone please update the PR to do so?
#1110 might be enough though.

Update: Never mind, reverted C#9 changes

@childish-sambino childish-sambino changed the title Nullable support feat: Nullable support Mar 28, 2022
@childish-sambino childish-sambino changed the title feat: Nullable support feat: add Nullable support Mar 28, 2022
@maxkoshevoi maxkoshevoi changed the title feat: add Nullable support feat: Add Nullable support Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beebzz beebzz beebzz left review comments

@Felix200521 Felix200521 Felix200521 approved these changes

@childish-sambino childish-sambino Awaiting requested review from childish-sambino

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maxkoshevoi @beebzz @childish-sambino @Felix200521 @shwetha-manvinkurke @JenniferMah