Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a unittest to check the license.md file date range #250

Closed
thinkingserious opened this issue Oct 28, 2017 · 1 comment · Fixed by #255
Closed

Add a unittest to check the license.md file date range #250

thinkingserious opened this issue Oct 28, 2017 · 1 comment · Fixed by #255
Labels
difficulty: unknown or n/a fix is unknown in difficulty

Comments

@thinkingserious
Copy link
Contributor

The end year in the license file should be "this year" and this should be checked on every run of the tests. If the end year is no correct, fail the test.
example:

Copyright (c) 2012-2016 SendGrid, Inc.
It is 2017, so this should be:
Copyright (c) 2012-2017 SendGrid, Inc.
and the test should fail.
--done
prashuchaudhary pushed a commit to prashuchaudhary/sendgrid-ruby that referenced this issue Oct 29, 2017
Add a unittest to check the license.md file date range sendgrid#250
76290f1
@prashuchaudhary prashuchaudhary mentioned this issue Oct 29, 2017
Merged
6 tasks
@prashuchaudhary
Copy link

prashuchaudhary commented Oct 29, 2017 •
edited
Loading

@thinkingserious Added the Unit Test to check Year range

mbernier pushed a commit that referenced this issue Nov 1, 2017
Merge pull request #255 from prashuchaudhary/master
0991f0d 
Add a unittest to check the license.md file date range #250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: unknown or n/a fix is unknown in difficulty
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a unittest to check the license.md file date range #250 prashuchaudhary/sendgrid-ruby
2 participants
@thinkingserious @prashuchaudhary