Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#197] Make SendGrid permissions management easy #278

Merged
merged 2 commits into from
Oct 23, 2018
Merged

[#197] Make SendGrid permissions management easy #278

merged 2 commits into from
Oct 23, 2018

Conversation

sony-mathew
Copy link
Contributor

Closes #197

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Created a scopes.yaml with all scopes, and a scope class with methods for each endpoints to get read only & full access permissions
  • wrote tests for the same as well as added examples

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@sony-mathew
[#197] Make SendGrid permissions management easy
988eb94 
- all scopes in scopes.yaml
- easy classes for read only & full access permission in scope class
- tests for the same, added it to rake
- added usage examples in scopes example
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 9, 2017
clee
clee reviewed Feb 12, 2018
View reviewed changes
Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clee clee added triaged and removed status: code review request requesting a community code review or review from Twilio triaged labels Feb 12, 2018
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
@thinkingserious thinkingserious merged commit 89bd916 into sendgrid:master Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @sony-mathew,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clee clee clee left review comments

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make SendGrid permissions management easy
3 participants
@sony-mathew @thinkingserious @clee