Extend Gem with additional Template and Recipient Functionality (round 2) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! We'll get to this as soon as we can. |
added 17 commits
October 19, 2015 13:01
This will add filters to the smtpapi gem: https://github.com/sendgrid/smtpapi-ruby The template_id will be passed in like other attributes to mail Example: ``` mail = SendGrid::Mail.new do |m| m.to = '[email protected]' m.from = '[email protected]' m.subject = 'Hello world!' m.text = 'I heard you like pineapple.' m.template_id = 1234 end ```
To help encapsulate the substitution logic for templates and how they correlate with email recipients, this model has been introduced. The benefit is now something like this is possible: ```ruby template = Template.new(TEMPLATE_ID) users = User.find(['[email protected]', '[email protected]']) users.each do |user| recipient = Recipient.new(user) recipient.add_substitution(:name, user.name) recipient.add_substitution(:location, user.location) template.add_recipient(recipient) end ``` The next step will be to integrate the `Recipient` and `Template` with `Mail`.
This will add an accessor for the template without an initialization through a template_id
This is the final piece of abstracting recipients, templates and the sending of mail. The use of this would look like: ```ruby users = User.where(email: ['[email protected]', '[email protected]']) recipients = [] users.each do |user| recipient = SendGrid::Recipient.new(user.email) recipient.add_substitution('first_name', user.first_name) recipient.add_substitution('city', user.city) recipients << recipient end template = SendGrid::Template.new('MY_TEMPLATE_ID') client = SendGrid::Client.new(api_user: my_user, api_key: my_key) mail_defaults = { from: '[email protected]', html: '<h1>I like email</h1>', text: 'I like email' subject: 'Email is great', } mailer = TemplateMailer.new(client, template, recipients) mailer.mail(mail_defaults) ```
thinkingserious
added a commit
that referenced
this pull request
Oct 28, 2015
Extend Gem with additional Template and Recipient Functionality (round 2)
|
Thanks for contributing to SendGrid Open Source! We think it's awesome when community members contribute to our projects and want to celebrate that. The following link will ask you to authenticate with Github (so we can verify your identity). You'll then be asked for your shipping address so that we can send you a thanks for contributing. Once again, thank you! |
|
Glad to contribute and thanks for the shirt! |
jamietanna
pushed a commit
to jamietanna/sendgrid-ruby
that referenced
this pull request
Oct 13, 2018
update readme - add license, remove logo from bottom, add ToC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thinkingserious
After #23, I have successfully added my changes to the new version of the gem.
Templateto aMailobject.Mailobject has atemplatewhen the Mail'sto_hmethod is called, it automatically adds the required template parameters to thesmtpapiheader.README.Recipientof template substitutions.
SMTPAPITemplatetemplate_idand managingRecipientsSMTPAPITemplateMailerTemplateand 1 to manyRecipientsMailandClientobjects to handle actual deliveryrequirepattern.