Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make inclusion of sinatra optional #284

Merged
merged 2 commits into from
Oct 23, 2018
Merged

make inclusion of sinatra optional #284

merged 2 commits into from
Oct 23, 2018

Conversation

jjb
Copy link
Contributor

@jjb jjb commented Feb 9, 2018

from discussion in #175

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Feb 9, 2018
@SendGridDX
Copy link

SendGridDX commented Feb 9, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jjb jjb force-pushed the optional-sinatra-dependency branch from 8b62148 to 78368b8 Compare February 9, 2018 05:47
clee
clee reviewed Feb 12, 2018
View reviewed changes
Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clee clee added triaged and removed status: code review request requesting a community code review or review from Twilio labels Feb 12, 2018
@jjb
Copy link
Contributor Author

jjb commented Feb 13, 2018 •
edited
Loading

the CI failures seem to be unrelated to my work... i could test this by submitting another PR off of master with a dummy commit, but don't want to confuse things / waste resources. let me know if you think my PR is the cause of the failures and i'll look into it.

@clee
Copy link

clee commented Feb 13, 2018

No, those failures don’t appear to be related to your code. Don’t worry about making any changes yet; you might need to rebase after some other PRs get merged though.

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy and removed status: code review complete status: code review request requesting a community code review or review from Twilio labels Feb 27, 2018
@joevandyk
Copy link

what's needed to be done on this?

@thinkingserious
Copy link
Contributor

Hello @joevandyk,

The ball is in our court to merge this. It's on our backlog to merge and your vote has been added to help boost the priority.

With Best Regards,

Elmer

@thinkingserious thinkingserious merged commit 7c6629b into sendgrid:master Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @jjb,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@jjb jjb deleted the optional-sinatra-dependency branch October 23, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clee clee clee left review comments

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jjb @SendGridDX @clee @joevandyk @thinkingserious