Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor getters and setters to use ruby accessors #338

Merged
merged 3 commits into from
Sep 4, 2020
Merged

chore: Refactor getters and setters to use ruby accessors #338

merged 3 commits into from
Sep 4, 2020

Conversation

douglaslise
Copy link
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 11, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 11, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@devchas devchas added hacktoberfest difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 15, 2018
@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:35
This was referenced Jul 29, 2020
Closed
Closed
@eshanholtz eshanholtz changed the title Refactor getters and setters to use ruby accessors chore: Refactor getters and setters to use ruby accessors Sep 2, 2020
eshanholtz
eshanholtz approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution 🎉

@eshanholtz eshanholtz merged commit 1d1bf33 into sendgrid:main Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Getters/Setters to use Ruby Accessors
6 participants
@douglaslise @SendGridDX @eshanholtz @thinkingserious @devchas @childish-sambino