Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Raise error when adding duplicate email address in Personalizations #437

Merged
merged 2 commits into from
Sep 23, 2020
Merged

fix: Raise error when adding duplicate email address in Personalizations #437

merged 2 commits into from
Sep 23, 2020

Conversation

pranc1ngpegasus
Copy link
Contributor

fix: Checking duplicate email address specified into personalizations as case insensitive

Fixes #436

Checking duplicate email address specified into personalizations as case insensitive

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 23, 2020
@pranc1ngpegasus pranc1ngpegasus marked this pull request as ready for review September 23, 2020 14:03
@eshanholtz eshanholtz changed the title Checking duplicate email address specified into personalizations as c… fix!: Raise error when adding duplicate email address in Personalizations Sep 23, 2020
eshanholtz
eshanholtz approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@eshanholtz eshanholtz merged commit 7c19b84 into sendgrid:main Sep 23, 2020
childish-sambino
childish-sambino reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a breaking change that warrants a MV roll?

lib/sendgrid/helpers/mail/personalization.rb Show resolved Hide resolved
@eshanholtz eshanholtz changed the title fix!: Raise error when adding duplicate email address in Personalizations fix: Raise error when adding duplicate email address in Personalizations Sep 24, 2020
@tmimura39 tmimura39 mentioned this pull request Oct 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz approved these changes

@childish-sambino childish-sambino childish-sambino left review comments

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checking duplicate email address specified into personalizations as case insensitive
4 participants
@pranc1ngpegasus @eshanholtz @childish-sambino @thinkingserious