Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reading position of a request body #440

Merged
merged 3 commits into from
Sep 29, 2020
Merged

fix: reading position of a request body #440

merged 3 commits into from
Sep 29, 2020

Conversation

snaka
Copy link
Contributor

@snaka snaka commented Sep 26, 2020 •
edited
Loading

Fixes #441

Fix reading position of a request body which middleware passed to an application.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file It has not changed any functionalities.
  • have added inline documentation to the code I modified Modified codes are absolutely obvious

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 26, 2020
@snaka snaka marked this pull request as ready for review September 26, 2020 14:54
eshanholtz
eshanholtz approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 🎉

lib/rack/sendgrid_webhook_verification.rb
@@ -39,6 +39,8 @@ def call(env)
request.env[SendGrid::EventWebhookHeader::TIMESTAMP]
)

request.body.rewind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@eshanholtz eshanholtz merged commit 969ef94 into sendgrid:main Sep 29, 2020
@snaka snaka deleted the fix_reading_position_of_request_body branch September 29, 2020 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SendGridWebhookVerification middleware unexpectedly changes request body's reading position
3 participants
@snaka @eshanholtz @thinkingserious