Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add http_options as a param in the SendGrid::API's constructor #455

Merged
merged 5 commits into from
Jan 30, 2021
Merged

feat: Add http_options as a param in the SendGrid::API's constructor #455

merged 5 commits into from
Jan 30, 2021

Conversation

hoangtuanictvn
Copy link
Contributor

@hoangtuanictvn hoangtuanictvn commented Jan 10, 2021 •
edited
Loading

Closes #449

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added inline documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 10, 2021
@hoangtuanictvn hoangtuanictvn force-pushed the http_options-as-param-in-constructor branch 4 times, most recently from 76497f9 to 885a2f9 Compare January 10, 2021 15:41
@hoangtuanictvn
Copy link
Contributor Author

hoangtuanictvn commented Jan 10, 2021 •
edited
Loading

Because the mistake in implement of sendgrid/ruby-http-client#67 in the ruby-http-client, the http_options didn't set right. So, the test in CI had failed to assert some value in http_options.

I also fixed it here sendgrid/ruby-http-client#124

I will update the ruby-http-client dependency of this sendgrid-ruby gem when the new version were released. And I hope the test of this PR is going to pass.

@hoangtuanictvn hoangtuanictvn mentioned this pull request Jan 10, 2021
Merged
7 tasks
@hoangtuanictvn hoangtuanictvn changed the title WIP - feat: Add http_options as a params of contructor WIP - feat: Add http_options as a param of contructor Jan 10, 2021
@hoangtuanictvn hoangtuanictvn changed the title WIP - feat: Add http_options as a param of contructor WIP - feat: Add http_options as a param of the SendGrid::API's constructor Jan 10, 2021
@hoangtuanictvn hoangtuanictvn changed the title WIP - feat: Add http_options as a param of the SendGrid::API's constructor WIP - feat: Add http_options as a param in the SendGrid::API's constructor Jan 10, 2021
@hoangtuanictvn hoangtuanictvn force-pushed the http_options-as-param-in-constructor branch from 885a2f9 to ecd285d Compare January 10, 2021 16:16
@hoangtuanictvn hoangtuanictvn changed the title WIP - feat: Add http_options as a param in the SendGrid::API's constructor feat: Add http_options as a param in the SendGrid::API's constructor Jan 15, 2021
@hoangtuanictvn hoangtuanictvn force-pushed the http_options-as-param-in-constructor branch 2 times, most recently from 699adf3 to 37cb181 Compare January 15, 2021 11:10
@hoangtuanictvn hoangtuanictvn force-pushed the http_options-as-param-in-constructor branch from 37cb181 to 6757832 Compare January 15, 2021 11:18
@hoangtuanictvn
Copy link
Contributor Author

hoangtuanictvn commented Jan 15, 2021 •
edited
Loading

Hello owners of this gem.

Because of some problem in the SSL certificate only in jruby:9.2, the test had failed. However, I didn't know more about the configs in your CI.
So, I'm happy to waiting for any owner to figure out for me about this problem.

Sorry for my mistake. I had used an unavailable mocked endpoint for the test. So the error occurs. I had fixed it. Everything seems good.

@hoangtuanictvn hoangtuanictvn force-pushed the http_options-as-param-in-constructor branch 2 times, most recently from 989c0e9 to 7d42378 Compare January 15, 2021 18:10
@hoangtuanictvn hoangtuanictvn force-pushed the http_options-as-param-in-constructor branch from 7d42378 to 22ec9c0 Compare January 15, 2021 18:14
JenniferMah
JenniferMah reviewed Jan 20, 2021
View reviewed changes
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @hoangtuanictvn!

.rubocop_todo.yml Show resolved Hide resolved
eshanholtz
eshanholtz approved these changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@eshanholtz eshanholtz merged commit 6785741 into sendgrid:main Jan 30, 2021
@hoangtuanictvn hoangtuanictvn deleted the http_options-as-param-in-constructor branch February 1, 2021 01:13
@hoangtuanictvn hoangtuanictvn mentioned this pull request Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenniferMah JenniferMah JenniferMah left review comments

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Make it possible to pass http_options config when initialize API
4 participants
@hoangtuanictvn @eshanholtz @JenniferMah @thinkingserious