Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleshing out the skeleton README 💀 #8

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Fleshing out the skeleton README 💀 #8

merged 2 commits into from
Nov 21, 2017

Conversation

mbbroberg
Copy link
Contributor

Fixes #1

  • Giving further context on how someone might use this file
  • Providing a - hopefully - inspirational checklist to follow

General

  • Update Changelog following the conventions laid out here

* Giving further context on how someone might use this file
* Providing a - hopefully - inspirational checklist to follow
@mbbroberg
Copy link
Contributor Author

Does this warrant a CHANGELOG entry? Not sure.

@mbbroberg
Copy link
Contributor Author

I missed the opportunity to write "💀->😛" for fleshing out 😆. Darn.

Copy link
Member

@majormoses majormoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also want to mention some basic stuff about testing. I know that we don't really have a great document on how we do that but we do have some great examples. I really need to get on that when I have
the time.

## Files
* Copy the files in this repository if you want to write a Ruby plugin following best practices of layout and structure
* To write the actual functionality, you'll need to import [Sensu Plugin gem](https://github.com/sensu-plugins/sensu-plugin)
* If you'd prefer writing in Python, use the [Python Plugin library](https://github.com/sensu-plugins/sensu-plugin-python)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment I still encourage copying and packaging it as a gem an addition to a pypi packages. The reason is that this now introduces 2 ways to install plugins. This is especially true since many plugins that have python, ruby, (bash|powershell) in the same project. While this is a larger discussion: sensu-plugins/community#70 I just wanted to point out and decide if we want to adjust any verbiage here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I think I can mention that as another checkbox below 9: "Regardless of the programming language, complete the gem packaging so its easily installed." How's that read? Any link on further details?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite yet a link but that being said here is a good example of why:
image
This is the mongo plugin if you are wondering.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stance will likely change at some point in the future as sensu will no longer NEED a ruby runtime so it's packaging may no longer be the defacto standard. Once this happens it opens up a lot of requests regarding reducing footprint for special use cases such as embedded devices and containers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majormoses I'm with you. It's a great call to mention is and I'm happy linking to Mongo as an example. Doesn't have to be canonical, just something.

@mbbroberg
Copy link
Contributor Author

☝️ I think that'll address your request. Thanks for the feedback as always 🤗

@majormoses majormoses merged commit 810def9 into master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants