Update zpool.rb #28
Open
Update zpool.rb #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
's/sudo\ //g'
|
Any chance this gets merged in this decade? We also need this, really don't want to have to bother with a fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
's/sudo\ //g'
Pull Request Checklist
Is this in reference to an existing issue?
No.
Purpose
Tried this plugin in our sensu environment today and noticed that it was returning "OK" but only after a sudo error on the line above which completely cancelled the script's logic out.
This plugin (At least on zfs-0.8+) runs perfectly fine without sudo and is able to observe all pools and properly report when there's a disk error all without sudo and is working perfectly fine in my environment without needing to configure sudo anymore.
Perhaps this isn't the route you want to go, but I figured I'd share this here as it seems to work best for our environment without sudoing just to check stats any account may access by default or by policy.
Known Compatibility Issues
None discovered yet. Intentionally broke test pool and script detected and threw an error state as expected.