Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit geopandas version to <1 #796

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

zigaLuksic
Copy link
Collaborator

No description provided.

@batic batic self-requested a review June 26, 2024 09:44
@zigaLuksic
Copy link
Collaborator Author

@batic the pylint errors are complete nonsense
I was thinking of just merging with a failed build, but i can just disable pylint for this release

@zigaLuksic
Copy link
Collaborator Author

@batic the pylint errors are complete nonsense I was thinking of just merging with a failed build, but i can just disable pylint for this release

I'm leaning towards releasing with a failing build, because disabling pylint doesnt really solve anything, and this way we can reinvestigate when i get back.

@zigaLuksic
Copy link
Collaborator Author

others are experiencing the same pylint issues, so i'm going forward with the release

@zigaLuksic zigaLuksic merged commit 83e44c3 into develop Jun 26, 2024
6 of 7 checks passed
@zigaLuksic zigaLuksic deleted the fix-geopandas-version-sub-1 branch June 26, 2024 10:51
@mlubej
Copy link
Contributor

mlubej commented Jun 26, 2024

Just linking for transparency: pylint-dev/pylint#9751

Probably a pylint bug or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants