Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature unit test #41

Merged
merged 22 commits into from
Sep 7, 2023
Merged

Feature unit test #41

merged 22 commits into from
Sep 7, 2023

Conversation

lincoln1883
Copy link
Collaborator

For this milestone, we completed unit and integration tests for the application components.

  • fix bugs.
  • add authorization.
  • add missing test cases.
  • refactorization.

@lincoln1883
Add conditional for logout button.
4a10d1e
@lincoln1883
Add authentication with cancancan.
a8004f7
@lincoln1883
Add authentication with cancancan.
b3a5d0b
@lincoln1883
Add authentication with cancancan.
04bed48
@lincoln1883
Change the Title.
71af630
@lincoln1883
Add the modal into a partial.
8a6a777
@lincoln1883
Merge branch 'dev' into feature-unit-test
935151f
@lincoln1883
Rename the post to inventory params.
a46a76e
@lincoln1883
Removed user.
631432f
@lincoln1883
Removed user because route doesnt exist.
31969f6
@lincoln1883
Removed empty examples.
689870c
@lincoln1883
Modified test cases to pass.
9e18e37
@lincoln1883
Modified route params for cases to pass.
a144cd4
@lincoln1883
Removed unwanted code.
1d31bf1
@lincoln1883
Removed empty tests.
746bf6c
@lincoln1883
Removed empty tests.
fbd9877
@lincoln1883
Add test case for form.
a761b5e
@lincoln1883
Add user params.
4f006fa
@lincoln1883
Add devise user params.
d535932
@lincoln1883
Add user params for validation.
0702134
@lincoln1883
Wrapped links inside conditional statement.
7ef3ffa
@lincoln1883
Fix linter errors.
e3b4d6d
@seperalta22 seperalta22 self-requested a review September 7, 2023 22:53
seperalta22
seperalta22 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Owner

@seperalta22 seperalta22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job Lincoln! 🚀
Approved! 🎉

@lincoln1883 lincoln1883 merged commit 28ebbb2 into dev Sep 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seperalta22 seperalta22 seperalta22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lincoln1883 @seperalta22