-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom java truststore support and improved exception handling #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks Esha!
I tried running this on my QL2 test-runs by just switching out the revision. I guess the https://cloud.seqera.io/orgs/scidev/workspaces/testing/watch/3qH91IevSxwp0Z Is setting the param java_truststore_path mandatory? |
Looks great @ejseqera ! I'll have a play locally to see if I can get the tests passing. Be good to confirm that this works in the real-world too. |
I currently get this in the console but it doesn't fail:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Adds better exception handling in try/catch for general unexpected runtime exceptions (i.e. NullPointerException, MissingPropertyException) and for HTTP response exceptions specific to calls made by REST client.
Adds support for providing custom
cacerts
if used by Seqera Platform Enterprise instances to be used by REST client infunctions.nf
and to propagate totw
CLI call inSEQERA_RUN_DUMPS
processPR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).